From 2020c7e821bb4826d0b4b46af42fd6e07f7e4c84 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 24 Apr 2023 09:51:46 +0200 Subject: [PATCH] qemuxml2argvtest: Drop needless PCI backend setting The qemuxml2argvtest does a bit of 'fixups' to parsed virDomainDef just before generating the cmd line. For instance, it sets PCI backend for hostdevs (to VFIO). The reason for this is that we want to make the test host independent and thus letting the code chose backend at runtime might render different results on different machines. But this is not necessary, as virpcimock (that the test uses) already creates a fake, but stable environment (where /dev/vfio/vfio and IOMMU groups exist), thus qemuHostdevHostSupportsPassthroughVFIO() returns true, regardless of the actual host support. Signed-off-by: Michal Privoznik Reviewed-by: Martin Kletzander --- tests/qemuxml2argvtest.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 270d6fa59e..276b1ac68b 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -407,12 +407,6 @@ testCompareXMLToArgvCreateArgs(virQEMUDriver *drv, for (i = 0; i < vm->def->nhostdevs; i++) { virDomainHostdevDef *hostdev = vm->def->hostdevs[i]; - if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && - hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI && - hostdev->source.subsys.u.pci.backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) { - hostdev->source.subsys.u.pci.backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO; - } - if (virHostdevIsSCSIDevice(hostdev)) { virDomainHostdevSubsysSCSI *scsisrc = &hostdev->source.subsys.u.scsi;