From 205518836376ca6be499f6ea985671284227d5f8 Mon Sep 17 00:00:00 2001
From: Roman Bogorodskiy <bogorodskiy@gmail.com>
Date: Thu, 31 Jan 2019 16:37:01 +0400
Subject: [PATCH] bhyve: emit warning when using bhyve:commandline
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
When using custom command line arguments, warn that
this configuration is not fully supported.
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
src/bhyve/bhyve_command.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index a1ae2026a0..1f215dac08 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -630,6 +630,10 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn,
if (def->namespaceData) {
bhyveDomainCmdlineDefPtr bhyvecmd;
+ VIR_WARN("Booting the guest using command line pass-through feature, "
+ "which could potentially cause inconsistent state and "
+ "upgrade issues");
+
bhyvecmd = def->namespaceData;
for (i = 0; i < bhyvecmd->num_args; i++)
virCommandAddArg(cmd, bhyvecmd->args[i]);