diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 9c8c262cc8..9d09b3a606 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -1463,158 +1463,155 @@ qemuDomainAssignPCIAddresses(virDomainDefPtr def, int ret = -1; virDomainPCIAddressSetPtr addrs = NULL; qemuDomainObjPrivatePtr priv = NULL; + int max_idx = -1; + int nbuses = 0; + size_t i; + int rv; + bool buses_reserved = true; - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { - int max_idx = -1; - int nbuses = 0; - size_t i; - int rv; - bool buses_reserved = true; + virDomainPCIConnectFlags flags = VIR_PCI_CONNECT_TYPE_PCI_DEVICE; - virDomainPCIConnectFlags flags = VIR_PCI_CONNECT_TYPE_PCI_DEVICE; + for (i = 0; i < def->ncontrollers; i++) { + if (def->controllers[i]->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI) { + if ((int) def->controllers[i]->idx > max_idx) + max_idx = def->controllers[i]->idx; + } + } - for (i = 0; i < def->ncontrollers; i++) { - if (def->controllers[i]->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI) { - if ((int) def->controllers[i]->idx > max_idx) - max_idx = def->controllers[i]->idx; - } + nbuses = max_idx + 1; + + if (nbuses > 0 && + virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_PCI_BRIDGE)) { + virDomainDeviceInfo info; + + /* 1st pass to figure out how many PCI bridges we need */ + if (!(addrs = qemuDomainPCIAddressSetCreate(def, nbuses, true))) + goto cleanup; + + if (qemuDomainValidateDevicePCISlotsChipsets(def, qemuCaps, + addrs) < 0) + goto cleanup; + + for (i = 0; i < addrs->nbuses; i++) { + if (!qemuDomainPCIBusFullyReserved(&addrs->buses[i])) + buses_reserved = false; } - nbuses = max_idx + 1; + /* Reserve 1 extra slot for a (potential) bridge only if buses + * are not fully reserved yet + */ + if (!buses_reserved && + virDomainPCIAddressReserveNextSlot(addrs, &info, flags) < 0) + goto cleanup; - if (nbuses > 0 && - virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_PCI_BRIDGE)) { - virDomainDeviceInfo info; + if (qemuDomainAssignDevicePCISlots(def, qemuCaps, addrs) < 0) + goto cleanup; - /* 1st pass to figure out how many PCI bridges we need */ - if (!(addrs = qemuDomainPCIAddressSetCreate(def, nbuses, true))) + for (i = 1; i < addrs->nbuses; i++) { + virDomainPCIAddressBusPtr bus = &addrs->buses[i]; + + if ((rv = virDomainDefMaybeAddController( + def, VIR_DOMAIN_CONTROLLER_TYPE_PCI, + i, bus->model)) < 0) goto cleanup; - - if (qemuDomainValidateDevicePCISlotsChipsets(def, qemuCaps, - addrs) < 0) - goto cleanup; - - for (i = 0; i < addrs->nbuses; i++) { - if (!qemuDomainPCIBusFullyReserved(&addrs->buses[i])) - buses_reserved = false; - } - - /* Reserve 1 extra slot for a (potential) bridge only if buses - * are not fully reserved yet - */ - if (!buses_reserved && + /* If we added a new bridge, we will need one more address */ + if (rv > 0 && virDomainPCIAddressReserveNextSlot(addrs, &info, flags) < 0) goto cleanup; - - if (qemuDomainAssignDevicePCISlots(def, qemuCaps, addrs) < 0) - goto cleanup; - - for (i = 1; i < addrs->nbuses; i++) { - virDomainPCIAddressBusPtr bus = &addrs->buses[i]; - - if ((rv = virDomainDefMaybeAddController( - def, VIR_DOMAIN_CONTROLLER_TYPE_PCI, - i, bus->model)) < 0) - goto cleanup; - /* If we added a new bridge, we will need one more address */ - if (rv > 0 && - virDomainPCIAddressReserveNextSlot(addrs, &info, flags) < 0) - goto cleanup; - } - nbuses = addrs->nbuses; - virDomainPCIAddressSetFree(addrs); - addrs = NULL; - - } else if (max_idx > 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("PCI bridges are not supported " - "by this QEMU binary")); - goto cleanup; } + nbuses = addrs->nbuses; + virDomainPCIAddressSetFree(addrs); + addrs = NULL; - if (!(addrs = qemuDomainPCIAddressSetCreate(def, nbuses, false))) + } else if (max_idx > 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("PCI bridges are not supported " + "by this QEMU binary")); + goto cleanup; + } + + if (!(addrs = qemuDomainPCIAddressSetCreate(def, nbuses, false))) + goto cleanup; + + if (qemuDomainSupportsPCI(def, qemuCaps)) { + if (qemuDomainValidateDevicePCISlotsChipsets(def, qemuCaps, + addrs) < 0) goto cleanup; - if (qemuDomainSupportsPCI(def, qemuCaps)) { - if (qemuDomainValidateDevicePCISlotsChipsets(def, qemuCaps, - addrs) < 0) - goto cleanup; + if (qemuDomainAssignDevicePCISlots(def, qemuCaps, addrs) < 0) + goto cleanup; - if (qemuDomainAssignDevicePCISlots(def, qemuCaps, addrs) < 0) - goto cleanup; + for (i = 0; i < def->ncontrollers; i++) { + virDomainControllerDefPtr cont = def->controllers[i]; + int idx = cont->idx; + virPCIDeviceAddressPtr addr; + virDomainPCIControllerOptsPtr options; - for (i = 0; i < def->ncontrollers; i++) { - virDomainControllerDefPtr cont = def->controllers[i]; - int idx = cont->idx; - virPCIDeviceAddressPtr addr; - virDomainPCIControllerOptsPtr options; + if (cont->type != VIR_DOMAIN_CONTROLLER_TYPE_PCI) + continue; - if (cont->type != VIR_DOMAIN_CONTROLLER_TYPE_PCI) - continue; + addr = &cont->info.addr.pci; + options = &cont->opts.pciopts; - addr = &cont->info.addr.pci; - options = &cont->opts.pciopts; + /* set default model name (the actual name of the + * device in qemu) for any controller that doesn't yet + * have it set. + */ + qemuDomainPCIControllerSetDefaultModelName(cont); - /* set default model name (the actual name of the - * device in qemu) for any controller that doesn't yet - * have it set. - */ - qemuDomainPCIControllerSetDefaultModelName(cont); - - /* set defaults for any other auto-generated config - * options for this controller that haven't been - * specified in config. - */ - switch ((virDomainControllerModelPCI)cont->model) { - case VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE: - if (options->chassisNr == -1) - options->chassisNr = cont->idx; - break; - case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT_PORT: - if (options->chassis == -1) - options->chassis = cont->idx; - if (options->port == -1) - options->port = (addr->slot << 3) + addr->function; - break; - case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT: - if (options->chassis == -1) - options->chassis = cont->idx; - if (options->port == -1) - options->port = addr->slot; - break; - case VIR_DOMAIN_CONTROLLER_MODEL_PCI_EXPANDER_BUS: - case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_EXPANDER_BUS: - if (options->busNr == -1) - options->busNr = qemuDomainAddressFindNewBusNr(def); - if (options->busNr == -1) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("No free busNr lower than current " - "lowest busNr is available to " - "auto-assign to bus %d. Must be " - "manually assigned"), - addr->bus); - goto cleanup; - } - break; - case VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE: - case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_UPSTREAM_PORT: - case VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT: - case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT: - case VIR_DOMAIN_CONTROLLER_MODEL_PCI_LAST: - break; - } - - /* check if every PCI bridge controller's ID is greater than - * the bus it is placed onto - */ - if (cont->model == VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE && - idx <= addr->bus) { + /* set defaults for any other auto-generated config + * options for this controller that haven't been + * specified in config. + */ + switch ((virDomainControllerModelPCI)cont->model) { + case VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE: + if (options->chassisNr == -1) + options->chassisNr = cont->idx; + break; + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT_PORT: + if (options->chassis == -1) + options->chassis = cont->idx; + if (options->port == -1) + options->port = (addr->slot << 3) + addr->function; + break; + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_DOWNSTREAM_PORT: + if (options->chassis == -1) + options->chassis = cont->idx; + if (options->port == -1) + options->port = addr->slot; + break; + case VIR_DOMAIN_CONTROLLER_MODEL_PCI_EXPANDER_BUS: + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_EXPANDER_BUS: + if (options->busNr == -1) + options->busNr = qemuDomainAddressFindNewBusNr(def); + if (options->busNr == -1) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("PCI controller at index %d (0x%02x) has " - "bus='0x%02x', but bus must be <= index"), - idx, idx, addr->bus); + _("No free busNr lower than current " + "lowest busNr is available to " + "auto-assign to bus %d. Must be " + "manually assigned"), + addr->bus); goto cleanup; } + break; + case VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE: + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_SWITCH_UPSTREAM_PORT: + case VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT: + case VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT: + case VIR_DOMAIN_CONTROLLER_MODEL_PCI_LAST: + break; + } + + /* check if every PCI bridge controller's ID is greater than + * the bus it is placed onto + */ + if (cont->model == VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE && + idx <= addr->bus) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("PCI controller at index %d (0x%02x) has " + "bus='0x%02x', but bus must be <= index"), + idx, idx, addr->bus); + goto cleanup; } } } @@ -1681,7 +1678,6 @@ qemuDomainReleaseDeviceAddress(virDomainObjPtr vm, VIR_WARN("Unable to release CCW address on %s", NULLSTR(devstr)); else if (info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI && - virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE) && virDomainPCIAddressReleaseSlot(priv->pciaddrs, &info->addr.pci) < 0) VIR_WARN("Unable to release PCI address on %s", diff --git a/tests/domainsnapshotxml2xmlout/disk_snapshot_redefine.xml b/tests/domainsnapshotxml2xmlout/disk_snapshot_redefine.xml index eb7f567135..297ca7fa81 100644 --- a/tests/domainsnapshotxml2xmlout/disk_snapshot_redefine.xml +++ b/tests/domainsnapshotxml2xmlout/disk_snapshot_redefine.xml @@ -70,12 +70,18 @@
- - + +
+ + +
+ - + +
+ 1 diff --git a/tests/domainsnapshotxml2xmlout/external_vm_redefine.xml b/tests/domainsnapshotxml2xmlout/external_vm_redefine.xml index e8e4640ddf..e2e7a40192 100644 --- a/tests/domainsnapshotxml2xmlout/external_vm_redefine.xml +++ b/tests/domainsnapshotxml2xmlout/external_vm_redefine.xml @@ -35,12 +35,18 @@
- - + +
+ + +
+ - + +
+ diff --git a/tests/domainsnapshotxml2xmlout/full_domain.xml b/tests/domainsnapshotxml2xmlout/full_domain.xml index 7d70a118c7..0b0b7e0cb5 100644 --- a/tests/domainsnapshotxml2xmlout/full_domain.xml +++ b/tests/domainsnapshotxml2xmlout/full_domain.xml @@ -28,12 +28,18 @@
- - + +
+ + +
+ - + +
+ 1 diff --git a/tests/domainsnapshotxml2xmlout/metadata.xml b/tests/domainsnapshotxml2xmlout/metadata.xml index 9a2c24fe14..f0d8d07941 100644 --- a/tests/domainsnapshotxml2xmlout/metadata.xml +++ b/tests/domainsnapshotxml2xmlout/metadata.xml @@ -32,12 +32,18 @@
- - + +
+ + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml b/tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml index 5bcc1a7eff..f4a471aae1 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml @@ -21,9 +21,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-boot-floppy.xml b/tests/qemuargv2xmldata/qemuargv2xml-boot-floppy.xml index a507558b8c..9bf4414b6e 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-boot-floppy.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-boot-floppy.xml @@ -26,10 +26,14 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-boot-network.xml b/tests/qemuargv2xmldata/qemuargv2xml-boot-network.xml index d060da61e4..b7e5ddef3b 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-boot-network.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-boot-network.xml @@ -20,9 +20,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-clock-localtime.xml b/tests/qemuargv2xmldata/qemuargv2xml-clock-localtime.xml index 7ffdb97bba..b039541231 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-clock-localtime.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-clock-localtime.xml @@ -20,9 +20,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml b/tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml index ecefafa66c..9beaf06ad3 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml @@ -20,9 +20,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml b/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml index 3768715522..5a17374990 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-console-compat.xml @@ -20,9 +20,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom-empty.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom-empty.xml index aaa7e32928..ea7653bf19 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom-empty.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom-empty.xml @@ -26,9 +26,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml index 146f453223..f8a7c779bf 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-cdrom.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-cdrom.xml index 29847630df..12d27d6f34 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-cdrom.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-cdrom.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-disk.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-disk.xml index 40ffdfc3bd..ab7a9ed18c 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-disk.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-boot-disk.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-directsync.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-directsync.xml index 5a12671f33..08198f59b7 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-directsync.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-directsync.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-unsafe.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-unsafe.xml index a6215bc29f..544524b53a 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-unsafe.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-unsafe.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-none.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-none.xml index 80640755bd..70c5576460 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-none.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-none.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wb.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wb.xml index 92d62508c7..8ee2360205 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wb.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wb.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wt.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wt.xml index 0ce353020b..a18fda7b91 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wt.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-cache-v2-wt.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-enospace.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-enospace.xml index 59b9262095..38f3877ee8 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-enospace.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-enospace.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-stop.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-stop.xml index 8be911e469..f3afc3f037 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-stop.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-stop.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-wreport-rignore.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-wreport-rignore.xml index fade9b67f4..d8eefcb0da 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-wreport-rignore.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-error-policy-wreport-rignore.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-fmt-qcow.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-fmt-qcow.xml index a9047193e8..d14710faf1 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-fmt-qcow.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-fmt-qcow.xml @@ -27,9 +27,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-gluster.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-gluster.xml index 0c66e7fd7e..160fd9d4bd 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-gluster.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-gluster.xml @@ -20,6 +20,7 @@ +
@@ -27,8 +28,11 @@ +
- + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi-auth.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi-auth.xml index b5f948b888..36da19e89c 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi-auth.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi-auth.xml @@ -23,6 +23,7 @@ +
@@ -30,8 +31,11 @@ +
- + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi.xml index 31fc9f28fa..05c731585c 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi.xml @@ -20,6 +20,7 @@ +
@@ -27,8 +28,11 @@ +
- + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-export.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-export.xml index 8f504813fe..74ec7589fa 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-export.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-export.xml @@ -26,10 +26,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6-export.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6-export.xml index a0557e0b8b..25a4fb8daa 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6-export.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6-export.xml @@ -26,10 +26,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6.xml index 2828249a82..979caf5b75 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-ipv6.xml @@ -26,10 +26,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-unix.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-unix.xml index 1a315b7242..fc08eb3152 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-unix.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd-unix.xml @@ -26,10 +26,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd.xml index feae85d821..9c2e959c10 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-nbd.xml @@ -26,10 +26,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-auth.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-auth.xml index bf82750925..c3ef946825 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-auth.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-auth.xml @@ -31,10 +31,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ceph-env.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ceph-env.xml index afa11ec608..928a30c67f 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ceph-env.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ceph-env.xml @@ -28,10 +28,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ipv6.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ipv6.xml index 7f73472f79..331b6b9a87 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ipv6.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd-ipv6.xml @@ -29,10 +29,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd.xml index d605aac5be..fd4e505400 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-rbd.xml @@ -28,6 +28,7 @@ +
@@ -35,6 +36,7 @@ +
@@ -45,6 +47,7 @@ +
@@ -53,10 +56,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-sheepdog.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-sheepdog.xml index 5868d5b720..0f789e2b8d 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-sheepdog.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-sheepdog.xml @@ -26,10 +26,15 @@ +
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-floppy.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-floppy.xml index 85f8b41828..ff31982253 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-floppy.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-floppy.xml @@ -32,10 +32,14 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml index 8ce58e32b7..834708c20f 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml @@ -38,9 +38,13 @@
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml index 729c3c0010..8bf3990876 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml @@ -25,9 +25,13 @@ - + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-virtio.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-virtio.xml index 9889132496..fb8ab06051 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-virtio.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-virtio.xml @@ -31,15 +31,21 @@ +
+
- + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-disk-xenvbd.xml b/tests/qemuargv2xmldata/qemuargv2xml-disk-xenvbd.xml index 2fe02f95f0..17c5e2c534 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-disk-xenvbd.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-disk-xenvbd.xml @@ -37,9 +37,13 @@ - + +
+ - + +
+ diff --git a/tests/qemuargv2xmldata/qemuargv2xml-graphics-sdl-fullscreen.xml b/tests/qemuargv2xmldata/qemuargv2xml-graphics-sdl-fullscreen.xml index 0bc0436fc1..5ff9913c9c 100644 --- a/tests/qemuargv2xmldata/qemuargv2xml-graphics-sdl-fullscreen.xml +++ b/tests/qemuargv2xmldata/qemuargv2xml-graphics-sdl-fullscreen.xml @@ -20,14 +20,19 @@
- + +
+ - + +
+