1
0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00

parallels: Avoid possible leak of "cpu" from parallelsBuildCapabilities

4d06af97d38c3648937eb8f732704379b3cd9e59 introduced a possible memory
leak of the memory allocated into the "cpu" pointer in
parallelsBuildCapabilities in the case "nodeGetInfo()" would fail right
after the allocation. Rearrange the code to avoid the possibility of the
leak.

Found by Coverity.
This commit is contained in:
Peter Krempa 2014-06-09 09:36:30 +02:00
parent df01390afc
commit 20d0c33aee

View File

@ -151,10 +151,10 @@ parallelsBuildCapabilities(void)
"parallels", NULL, NULL, 0, NULL) == NULL)
goto error;
if (VIR_ALLOC(cpu) < 0)
if (nodeGetInfo(&nodeinfo))
goto error;
if (nodeGetInfo(&nodeinfo))
if (VIR_ALLOC(cpu) < 0)
goto error;
cpu->arch = caps->host.arch;