External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virHostCPUHasValidSubcoreConfiguration: Refactor cleanup

Browse Source 
Use automatic memory freeing for the temporary bitmap and remove the
pointless 'cleanup' section.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2021-12-07 17:22:26 +01:00
parent 19228b6016
commit 20ddaa9797
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/util/virhostcpu.c
View File

@ -450,31 +450,25 @@ virHostCPUParseNode(const char *node,
static bool static bool
virHostCPUHasValidSubcoreConfiguration(int threads_per_subcore) virHostCPUHasValidSubcoreConfiguration(int threads_per_subcore)
{ {
virBitmap *online_cpus = NULL; g_autoptr(virBitmap) online_cpus = NULL;
int cpu = -1; int cpu = -1;
bool ret = false;
/* No point in checking if subcores are not in use */ /* No point in checking if subcores are not in use */
if (threads_per_subcore <= 0) if (threads_per_subcore <= 0)
goto cleanup; return false;
if (!(online_cpus = virHostCPUGetOnlineBitmap())) if (!(online_cpus = virHostCPUGetOnlineBitmap()))
goto cleanup; return false;
while ((cpu = virBitmapNextSetBit(online_cpus, cpu)) >= 0) { while ((cpu = virBitmapNextSetBit(online_cpus, cpu)) >= 0) {
/* A single online secondary thread is enough to /* A single online secondary thread is enough to
* make the configuration invalid */ * make the configuration invalid */
if (cpu % threads_per_subcore != 0) if (cpu % threads_per_subcore != 0)
goto cleanup; return false;
} }
ret = true; return true;
cleanup:
virBitmapFree(online_cpus);
return ret;
} }