External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-17 15:17:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virCPUx86DataIsIdentical: Add debug output

Browse Source 
Without this it's impossible to debug scenarios when this function
returns a mismatch but the formatted data looks identical.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2022-04-25 14:38:08 +02:00
parent 9223ebbc85
commit 210a195394
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/cpu/cpu_x86.c
View File

@ -3309,14 +3309,20 @@ virCPUx86DataIsIdentical(const virCPUData *a,
if (!a || !b)
return VIR_CPU_COMPARE_ERROR;
if (a->arch != b->arch)
if (a->arch != b->arch) {
VIR_DEBUG("incompatible architecture a:%u b:%u", a->arch, b->arch);
return VIR_CPU_COMPARE_INCOMPATIBLE;
}
if (!((adata = &a->data.x86) && (bdata = &b->data.x86)))
if (!((adata = &a->data.x86) && (bdata = &b->data.x86))) {
VIR_DEBUG("missing x86 data: a:%p b:%p", adata, bdata);
return VIR_CPU_COMPARE_ERROR;
}
if (adata->len != bdata->len)
if (adata->len != bdata->len) {
VIR_DEBUG("unequal length a:%zu b:%zu", adata->len, bdata->len);
return VIR_CPU_COMPARE_INCOMPATIBLE;
}
for (i = 0; i < adata->len; ++i) {
bool found = false;
@ -3330,8 +3336,10 @@ virCPUx86DataIsIdentical(const virCPUData *a,
break;
}
if (!found)
if (!found) {
VIR_DEBUG("mismatched data");
return VIR_CPU_COMPARE_INCOMPATIBLE;
}
}
return VIR_CPU_COMPARE_IDENTICAL;