External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 22:25:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: do not clear vols before volume upload

Browse Source 
Commit 5e54361c added virStoragePoolObjClearVols before refreshPool
to prevent duplicate volume entries.

However it is not needed here because we're not refreshing the pool yet,
just checking for the existence of the refresh callback.

The actual refresh is done via virStorageVolFDStreamCloseCb
in virStorageVolPoolRefreshThread, which already calls
virStoragePoolObjClearVols.
This commit is contained in:
Ján Tomko 2016-05-20 11:42:56 +02:00
parent 71cfa668eb
commit 21fdb4fe70
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/storage/storage_driver.c
View File

@ -2357,7 +2357,6 @@ storageVolUpload(virStorageVolPtr obj,
* interaction and we can just lookup the backend in the callback * interaction and we can just lookup the backend in the callback
* routine in order to call the refresh API. * routine in order to call the refresh API.
*/ */
virStoragePoolObjClearVols(pool);
if (backend->refreshPool) { if (backend->refreshPool) {
if (VIR_ALLOC(cbdata) < 0 || if (VIR_ALLOC(cbdata) < 0 ||
VIR_STRDUP(cbdata->pool_name, pool->def->name) < 0) VIR_STRDUP(cbdata->pool_name, pool->def->name) < 0)