From 2224989c396c6427269e4c050d6abf50f2690838 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Tue, 5 Jan 2010 11:51:04 +0000 Subject: [PATCH] Avoid free'ing a constant string in chardev lookup code * src/qemu/qemu_monitor_text.c: Don't free const string in qemuMonitorTextGetPtyPaths() --- src/qemu/qemu_monitor_text.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 52cd97ce1d..2b8c1e8f22 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -1678,14 +1678,12 @@ cleanup: int qemuMonitorTextGetPtyPaths(qemuMonitorPtr mon, virHashTablePtr paths) { - const char *cmd = "info chardev"; char *reply = NULL; int ret = -1; - if (qemuMonitorCommand(mon, cmd, &reply) < 0) { - qemudReportError(NULL, NULL, NULL, VIR_ERR_OPERATION_FAILED, - _("failed to retrieve chardev info in qemu with '%s'"), - cmd); + if (qemuMonitorCommand(mon, "info chardev", &reply) < 0) { + qemudReportError(NULL, NULL, NULL, VIR_ERR_OPERATION_FAILED, "%s", + _("failed to retrieve chardev info in qemu with 'info chardev'")); goto cleanup; } @@ -1747,7 +1745,6 @@ int qemuMonitorTextGetPtyPaths(qemuMonitorPtr mon, ret = 0; cleanup: - VIR_FREE(cmd); VIR_FREE(reply); return ret; }