External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-11-03 11:51:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Simplify size check for ppc64 NVDIMMs

Browse Source 
We already calculated the guest area, which is what is subject
to minimum size requirements, a few lines earlier.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
Andrea Bolognani 2020-12-02 19:08:45 +01:00
parent 7e9d180100
commit 2319253bcd
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/qemu/qemu_domain.c
View File

@ -5360,10 +5360,9 @@ qemuDomainNVDimmAlignSizePseries(virDomainMemoryDefPtr mem)
unsigned long long ppc64AlignSize = 256 * 1024; unsigned long long ppc64AlignSize = 256 * 1024;
unsigned long long guestArea = mem->size - mem->labelsize; unsigned long long guestArea = mem->size - mem->labelsize;
/* Align down guest_area. 256MiB is the minimum size. Error /* Align down guestArea. We can't align down if guestArea is
* out if target_size is smaller than 256MiB + label_size, * smaller than the 256MiB alignment. */
* since aligning it up will cause QEMU errors. */ if (guestArea < ppc64AlignSize) {
if (mem->size < (ppc64AlignSize + mem->labelsize)) {
virReportError(VIR_ERR_XML_ERROR, "%s", virReportError(VIR_ERR_XML_ERROR, "%s",
_("minimum target size for the NVDIMM " _("minimum target size for the NVDIMM "
"must be 256MB plus the label size")); "must be 256MB plus the label size"));