From 233afc3c585be462156d384f0c6b9dd33c1fa2c8 Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Mon, 21 Oct 2024 12:55:32 +0200 Subject: [PATCH] sync_qemu_models_i386: Do not overwrite existing models MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We don't change definitions of CPU models which were already included in a libvirt release to maintain migration compatibility. Thus the script can just skip existing models and save us from having to drop the changes it would do to them. Signed-off-by: Jiri Denemark Reviewed-by: Daniel P. Berrangé --- src/cpu_map/sync_qemu_models_i386.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu_map/sync_qemu_models_i386.py b/src/cpu_map/sync_qemu_models_i386.py index 78c2bffab2..f7b06a7716 100755 --- a/src/cpu_map/sync_qemu_models_i386.py +++ b/src/cpu_map/sync_qemu_models_i386.py @@ -535,6 +535,10 @@ def main(): for model in models: name = os.path.join(args.outdir, f"x86_{model['name']}.xml") + if os.path.isfile(name): + # Ignore existing models as CPU models in libvirt should never + # change once released. + continue with open(name, "wt") as f: output_model(f, model)