External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 14:15:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Implement DAC driver chown callback to co-operate with storage drv

Browse Source 
Use the storage driver to chown remote images.
This commit is contained in:
Peter Krempa 2014-07-10 15:46:01 +02:00
parent 0a515a3ba3
commit 24e5cafba6
1 changed files with 47 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/qemu/qemu_driver.c
View File

@ -327,6 +327,52 @@ qemuAutostartDomains(virQEMUDriverPtr driver)
virObjectUnref(cfg);
}
static int
qemuSecurityChownCallback(virStorageSourcePtr src,
uid_t uid,
gid_t gid)
{
struct stat sb;
int save_errno = 0;
int ret = -1;
if (!virStorageFileSupportsSecurityDriver(src))
return 0;
if (virStorageSourceIsLocalStorage(src)) {
/* use direct chmod for local files so that the file doesn't
* need to be initialized */
if (stat(src->path, &sb) >= 0) {
if (sb.st_uid == uid &&
sb.st_gid == gid) {
/* It's alright, there's nothing to change anyway. */
return 0;
}
}
return chown(src->path, uid, gid);
}
/* storage file init reports errors, return -2 on failure */
if (virStorageFileInit(src) < 0)
return -2;
if (virStorageFileChown(src, uid, gid) < 0) {
save_errno = errno;
goto cleanup;
}
ret = 0;
cleanup:
virStorageFileDeinit(src);
errno = save_errno;
return ret;
}
static int
qemuSecurityInit(virQEMUDriverPtr driver)
{
@ -375,7 +421,7 @@ qemuSecurityInit(virQEMUDriverPtr driver)
cfg->securityDefaultConfined,
cfg->securityRequireConfined,
cfg->dynamicOwnership,
NULL)))
qemuSecurityChownCallback)))
goto error;
if (!stack) {
if (!(stack = virSecurityManagerNewStack(mgr)))