From 2503e4b03c0003a8d60ce9483868dd3317deebcf Mon Sep 17 00:00:00 2001 From: Andrea Bolognani Date: Mon, 26 Jun 2017 19:13:28 +0200 Subject: [PATCH] conf: Copy loadparm in virDomainDeviceInfoCopy() Commit 54fa1b44afc8 added virDomainDeviceInfo::loadparm and updated virDomainDeviceInfoClear() accordingly, but omitted the necessary virDomainDeviceInfoCopy() changes. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index fdf85d5dd7..ce00dfa78d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3573,12 +3573,14 @@ virDomainDeviceInfoCopy(virDomainDeviceInfoPtr dst, /* first a shallow copy of *everything* */ *dst = *src; - /* then redo the two fields that are pointers */ + /* then copy whatever's left */ dst->alias = NULL; dst->romfile = NULL; + dst->loadparm = NULL; if (VIR_STRDUP(dst->alias, src->alias) < 0 || - VIR_STRDUP(dst->romfile, src->romfile) < 0) + VIR_STRDUP(dst->romfile, src->romfile) < 0 || + VIR_STRDUP(dst->loadparm, src->loadparm) < 0) return -1; return 0; }