mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 21:55:25 +00:00
qemu: process: Make it obvious that virDomainDefPostParse is called with NULL opaque
Commit c90fb5a828
added explicit use of the private copy of the qemu
capabilities to various places. The change to qemuProcessInit was bogus
though as at the point where we re-initiate the post parse callbacks
priv->qemuCaps is still NULL as we clear it after shutdown of the VM and
don't initiate it until a later point.
Using the value from priv->qemuCaps might mislead readers of the code
into thinking that something useful is being passed at that point so go
with an explicit NULL instead.
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
ab163144eb
commit
2504dbeb5d
@ -5531,7 +5531,8 @@ qemuProcessInit(virQEMUDriverPtr driver,
|
||||
if (vm->def->postParseFailed) {
|
||||
VIR_DEBUG("re-running the post parse callback");
|
||||
|
||||
if (virDomainDefPostParse(vm->def, caps, 0, driver->xmlopt, priv->qemuCaps) < 0)
|
||||
/* we don't have the private copy of qemuCaps at this point */
|
||||
if (virDomainDefPostParse(vm->def, caps, 0, driver->xmlopt, NULL) < 0)
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user