External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

examples: Try harder to uninstall nwfilter

Browse Source 
We have this code in our Makefile that tries to remove
/etc/libvirt/nwfilter if directory is left empty after all our
example nwfilters were uninstalled. However, the check for that
is missing quotation marks thus rendering the test useless:

test -z allow-arp.xml allow-dhcp-server.xml .. qemu-announce-self.xml || \
  rmdir "/some/path/libvirt.git/_install/etc/libvirt/nwfilter"
/bin/sh: line 0: test: too many arguments

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2016-04-19 11:13:00 +02:00
parent 2f3c89fbbb
commit 25866ec6a6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/Makefile.am
View File

@ -90,5 +90,5 @@ uninstall-local::
for f in $(FILTERS); do \ for f in $(FILTERS); do \
rm -f "$(NWFILTER_DIR)/`basename $$f`"; \ rm -f "$(NWFILTER_DIR)/`basename $$f`"; \
done done
-test -z $(shell ls $(NWFILTER_DIR)) || rmdir $(NWFILTER_DIR) -test -z "$(shell ls $(NWFILTER_DIR))" || rmdir $(NWFILTER_DIR)
endif WITH_NWFILTER endif WITH_NWFILTER