From 25ce34998ba713e2d0167315cb178cdebb02e7c8 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Tue, 9 May 2023 11:58:34 +0300 Subject: [PATCH] logging: Provide empty VIRTLOGD_ARGS in the unit file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For all our daemons, we provide VIRXXXD_ARGS env var in the unit file. The variable can then be overridden in corresponding file: EnvironmentFile=-@initconfdir@/virtxxxd The daemon is then executed as: ExecStart=@sbindir@/virtxxxd $VIRTXXXD_ARGS But virtlogd is exception, for no good reason. And while there are probably no arguments we want to pass to virtlogd by default, just mimic what we do for say virtlockd, where we also don't pass any default argument. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/logging/virtlogd.service.in | 1 + 1 file changed, 1 insertion(+) diff --git a/src/logging/virtlogd.service.in b/src/logging/virtlogd.service.in index 158124e4d3..e4aecd46a7 100644 --- a/src/logging/virtlogd.service.in +++ b/src/logging/virtlogd.service.in @@ -7,6 +7,7 @@ Documentation=man:virtlogd(8) Documentation=https://libvirt.org [Service] +Environment=VIRTLOGD_ARGS= EnvironmentFile=-@initconfdir@/virtlogd ExecStart=@sbindir@/virtlogd $VIRTLOGD_ARGS ExecReload=/bin/kill -USR1 $MAINPID