External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

xenapi: Improve error reporting in xenapiOpen

Browse Source 
Use better suited error code and avoid NULL in error messsage
as *privP->session->error_description can be NULL.
This commit is contained in:
Matthias Bolte 2011-07-14 16:58:43 +02:00
parent b8f36e74ad
commit 2682731d24
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/xenapi/xenapi_driver.c
View File

@ -106,7 +106,7 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth,
} }
if (conn->uri->server == NULL) { if (conn->uri->server == NULL) {
xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, xenapiSessionErrorHandler(conn, VIR_ERR_INVALID_ARG,
_("Server name not in URI")); _("Server name not in URI"));
goto error; goto error;
} }
@ -194,7 +194,9 @@ xenapiOpen (virConnectPtr conn, virConnectAuthPtr auth,
} }
xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED, xenapiSessionErrorHandler(conn, VIR_ERR_AUTH_FAILED,
*privP->session->error_description); *privP->session->error_description != NULL ?
*privP->session->error_description :
_("unknown error"));
error: error:
VIR_FREE(username); VIR_FREE(username);