External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-13 00:01:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential NULL dereference in remoteDomainMigratePrepare2

Browse Source
This commit is contained in:
Jiri Denemark 2010-05-12 16:52:06 +02:00
parent 49ed0a2e1b
commit 272d5a9653
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/remote/remote_driver.c
View File

@ -2849,17 +2849,34 @@ remoteDomainMigratePrepare2 (virConnectPtr dconn,
goto done; goto done;
if (ret.cookie.cookie_len > 0) { if (ret.cookie.cookie_len > 0) {
if (!cookie || !cookielen) {
remoteError(VIR_ERR_INTERNAL_ERROR, "%s",
_("caller ignores cookie or cookielen"));
goto error;
}
*cookie = ret.cookie.cookie_val; /* Caller frees. */ *cookie = ret.cookie.cookie_val; /* Caller frees. */
*cookielen = ret.cookie.cookie_len; *cookielen = ret.cookie.cookie_len;
} }
if (ret.uri_out) if (ret.uri_out) {
if (!uri_out) {
remoteError(VIR_ERR_INTERNAL_ERROR, "%s",
_("caller ignores uri_out"));
goto error;
}
*uri_out = *ret.uri_out; /* Caller frees. */ *uri_out = *ret.uri_out; /* Caller frees. */
}
rv = 0; rv = 0;
done: done:
remoteDriverUnlock(priv); remoteDriverUnlock(priv);
return rv; return rv;
error:
if (ret.cookie.cookie_len)
VIR_FREE(ret.cookie.cookie_val);
if (ret.uri_out)
VIR_FREE(*ret.uri_out);
goto done;
} }
static virDomainPtr static virDomainPtr