mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-22 22:13:18 +00:00
virDomainUndefineFlags: Allow NVRAM unlinking
When a domain is undefined, there are options to remove it's managed save state or snapshots. However, there's another file that libvirt creates per domain: the NVRAM variable store file. Make sure that the file is not left behind if the domain is undefined. Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
parent
245134fc1d
commit
273b6581ca
@ -2257,6 +2257,8 @@ typedef enum {
|
|||||||
VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA = (1 << 1), /* If last use of domain,
|
VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA = (1 << 1), /* If last use of domain,
|
||||||
then also remove any
|
then also remove any
|
||||||
snapshot metadata */
|
snapshot metadata */
|
||||||
|
VIR_DOMAIN_UNDEFINE_NVRAM = (1 << 2), /* Also remove any
|
||||||
|
nvram file */
|
||||||
|
|
||||||
/* Future undefine control flags should come here. */
|
/* Future undefine control flags should come here. */
|
||||||
} virDomainUndefineFlagsValues;
|
} virDomainUndefineFlagsValues;
|
||||||
|
@ -6408,7 +6408,8 @@ qemuDomainUndefineFlags(virDomainPtr dom,
|
|||||||
virQEMUDriverConfigPtr cfg = NULL;
|
virQEMUDriverConfigPtr cfg = NULL;
|
||||||
|
|
||||||
virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_SAVE |
|
virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_SAVE |
|
||||||
VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, -1);
|
VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA |
|
||||||
|
VIR_DOMAIN_UNDEFINE_NVRAM, -1);
|
||||||
|
|
||||||
if (!(vm = qemuDomObjFromDomain(dom)))
|
if (!(vm = qemuDomObjFromDomain(dom)))
|
||||||
return -1;
|
return -1;
|
||||||
@ -6457,6 +6458,23 @@ qemuDomainUndefineFlags(virDomainPtr dom,
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!virDomainObjIsActive(vm) &&
|
||||||
|
vm->def->os.loader && vm->def->os.loader->nvram &&
|
||||||
|
virFileExists(vm->def->os.loader->nvram)) {
|
||||||
|
if (!(flags & VIR_DOMAIN_UNDEFINE_NVRAM)) {
|
||||||
|
virReportError(VIR_ERR_OPERATION_INVALID, "%s",
|
||||||
|
_("cannot delete inactive domain with nvram"));
|
||||||
|
goto cleanup;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (unlink(vm->def->os.loader->nvram) < 0) {
|
||||||
|
virReportSystemError(errno,
|
||||||
|
_("failed to remove nvram: %s"),
|
||||||
|
vm->def->os.loader->nvram);
|
||||||
|
goto cleanup;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm) < 0)
|
if (virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm) < 0)
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
|
|
||||||
|
@ -3248,6 +3248,10 @@ static const vshCmdOptDef opts_undefine[] = {
|
|||||||
.type = VSH_OT_BOOL,
|
.type = VSH_OT_BOOL,
|
||||||
.help = N_("remove all domain snapshot metadata, if inactive")
|
.help = N_("remove all domain snapshot metadata, if inactive")
|
||||||
},
|
},
|
||||||
|
{.name = "nvram",
|
||||||
|
.type = VSH_OT_BOOL,
|
||||||
|
.help = N_("remove nvram file, if inactive")
|
||||||
|
},
|
||||||
{.name = NULL}
|
{.name = NULL}
|
||||||
};
|
};
|
||||||
|
|
||||||
@ -3270,6 +3274,7 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd)
|
|||||||
bool snapshots_metadata = vshCommandOptBool(cmd, "snapshots-metadata");
|
bool snapshots_metadata = vshCommandOptBool(cmd, "snapshots-metadata");
|
||||||
bool wipe_storage = vshCommandOptBool(cmd, "wipe-storage");
|
bool wipe_storage = vshCommandOptBool(cmd, "wipe-storage");
|
||||||
bool remove_all_storage = vshCommandOptBool(cmd, "remove-all-storage");
|
bool remove_all_storage = vshCommandOptBool(cmd, "remove-all-storage");
|
||||||
|
bool nvram = vshCommandOptBool(cmd, "nvram");
|
||||||
/* Positive if these items exist. */
|
/* Positive if these items exist. */
|
||||||
int has_managed_save = 0;
|
int has_managed_save = 0;
|
||||||
int has_snapshots_metadata = 0;
|
int has_snapshots_metadata = 0;
|
||||||
@ -3313,6 +3318,9 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd)
|
|||||||
flags |= VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA;
|
flags |= VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA;
|
||||||
snapshots_safe = true;
|
snapshots_safe = true;
|
||||||
}
|
}
|
||||||
|
if (nvram) {
|
||||||
|
flags |= VIR_DOMAIN_UNDEFINE_NVRAM;
|
||||||
|
}
|
||||||
|
|
||||||
if (!(dom = vshCommandOptDomain(ctl, cmd, &name)))
|
if (!(dom = vshCommandOptDomain(ctl, cmd, &name)))
|
||||||
return false;
|
return false;
|
||||||
@ -3503,10 +3511,14 @@ cmdUndefine(vshControl *ctl, const vshCmd *cmd)
|
|||||||
* VIR_DOMAIN_UNDEFINE_MANAGED_SAVE in 0.9.4, the
|
* VIR_DOMAIN_UNDEFINE_MANAGED_SAVE in 0.9.4, the
|
||||||
* VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA flag was not present
|
* VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA flag was not present
|
||||||
* until 0.9.5; skip to piecewise emulation if we couldn't prove
|
* until 0.9.5; skip to piecewise emulation if we couldn't prove
|
||||||
* above that the new API is safe. */
|
* above that the new API is safe.
|
||||||
if (managed_save_safe && snapshots_safe) {
|
* Moreover, only the newer UndefineFlags() API understands
|
||||||
|
* the VIR_DOMAIN_UNDEFINE_NVRAM flag. So if user has
|
||||||
|
* specified --nvram we must use the Flags() API. */
|
||||||
|
if ((managed_save_safe && snapshots_safe) || nvram) {
|
||||||
rc = virDomainUndefineFlags(dom, flags);
|
rc = virDomainUndefineFlags(dom, flags);
|
||||||
if (rc == 0 || (last_error->code != VIR_ERR_NO_SUPPORT &&
|
if (rc == 0 || nvram ||
|
||||||
|
(last_error->code != VIR_ERR_NO_SUPPORT &&
|
||||||
last_error->code != VIR_ERR_INVALID_ARG))
|
last_error->code != VIR_ERR_INVALID_ARG))
|
||||||
goto out;
|
goto out;
|
||||||
vshResetLibvirtError();
|
vshResetLibvirtError();
|
||||||
|
@ -2083,7 +2083,7 @@ Output the device used for the TTY console of the domain. If the information
|
|||||||
is not available the processes will provide an exit code of 1.
|
is not available the processes will provide an exit code of 1.
|
||||||
|
|
||||||
=item B<undefine> I<domain> [I<--managed-save>] [I<--snapshots-metadata>]
|
=item B<undefine> I<domain> [I<--managed-save>] [I<--snapshots-metadata>]
|
||||||
[ {I<--storage> B<volumes> | I<--remove-all-storage>} I<--wipe-storage>]
|
[I<--nvram>] [ {I<--storage> B<volumes> | I<--remove-all-storage>} I<--wipe-storage>]
|
||||||
|
|
||||||
Undefine a domain. If the domain is running, this converts it to a
|
Undefine a domain. If the domain is running, this converts it to a
|
||||||
transient domain, without stopping it. If the domain is inactive,
|
transient domain, without stopping it. If the domain is inactive,
|
||||||
@ -2099,6 +2099,10 @@ domain. Without the flag, attempts to undefine an inactive domain with
|
|||||||
snapshot metadata will fail. If the domain is active, this flag is
|
snapshot metadata will fail. If the domain is active, this flag is
|
||||||
ignored.
|
ignored.
|
||||||
|
|
||||||
|
The I<--nvram> flag ensures no nvram (/domain/os/nvram/) file is
|
||||||
|
left behind. If the domain has an nvram file and the flag is
|
||||||
|
omitted, the undefine will fail.
|
||||||
|
|
||||||
The I<--storage> flag takes a parameter B<volumes>, which is a comma separated
|
The I<--storage> flag takes a parameter B<volumes>, which is a comma separated
|
||||||
list of volume target names or source paths of storage volumes to be removed
|
list of volume target names or source paths of storage volumes to be removed
|
||||||
along with the undefined domain. Volumes can be undefined and thus removed only
|
along with the undefined domain. Volumes can be undefined and thus removed only
|
||||||
|
Loading…
Reference in New Issue
Block a user