External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

virDomainDetachDeviceFlags: Clarify update semantics

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=1621910

When users want to update a path to a CDROM they tend to
construct a very minimal XML and feed the API with it. This is
not a good practice as it breaks the assumptions the API is built
on. Most notably, leaving an element out should be treated as a
request for removal of the corresponding setting. Just like
leaving out <bandwidth/> clears out any QoS previously set.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Michal Privoznik 2018-08-27 15:40:33 +02:00
parent c04aa383ff
commit 2864b4cd1c
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libvirt-domain.c
View File

@ -8318,6 +8318,14 @@ virDomainDetachDeviceFlags(virDomainPtr domain,
* media, altering the graphics configuration such as password,
* reconfiguring the NIC device backend connectivity, etc.
*
* The supplied XML description of the device should contain all
* the information that is found in the corresponding domain XML.
* Leaving out any piece of information may be treated as a
* request for its removal, which may be denied. For instance,
* when users want to change CDROM media only for live XML, they
* must provide live disk XML as found in the corresponding live
* domain XML with only the disk path changed.
*
* Returns 0 in case of success, -1 in case of failure.
*/
int