External/libvirt
1
0
Fork 0
Code

rpc: Add coverity[dead_error_begin] tag

Browse Source 
Coverity misses the nuance of VIR_FREE(privkey) setting privkey = NULL when
if (!(virFileExists(privkey))) is true and thus declares the code dead.
This commit is contained in:
John Ferlan 2013-01-22 09:41:00 -05:00 committed by Michal Privoznik
parent 8b55992f4e
commit 28cd3dc40b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/rpc/virnetclient.c
View File

@ -430,6 +430,7 @@ virNetClientPtr virNetClientNewLibSSH2(const char *host,
VIR_FREE(privkey); VIR_FREE(privkey);
/* DSA */ /* DSA */
if (!privkey) { if (!privkey) {
/* coverity[dead_error_begin] */
virBufferAsprintf(&buf, "%s/.ssh/id_dsa", homedir); virBufferAsprintf(&buf, "%s/.ssh/id_dsa", homedir);
if (!(privkey = virBufferContentAndReset(&buf))) if (!(privkey = virBufferContentAndReset(&buf)))
goto no_memory; goto no_memory;