External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-15 17:15:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: lvm: lvcreate fails with allocation=0, don't do that

Browse Source 
On F17 at least, this command fails:

$ sudo /usr/sbin/lvcreate --name sparsetest -L 0K --virtualsize 16384K vgvirt
  Unable to create new logical volume with no extents

Which is unfortunate since allocation=0 is what virt-manager tries to use
by default.

Rather than telling the user 'don't do that', let's just give them the
smallest allocation possible if alloc=0 is requested.

https://bugzilla.redhat.com/show_bug.cgi?id=866481
(cherry picked from commit 9f0e9cba27b3e2b8409f2ce1c0ed4d24d677be9b)
This commit is contained in:
Cole Robinson 2012-10-16 20:30:23 -04:00
parent 95440c51a0
commit 29a2a91187
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/storage/storage_backend_logical.c
View File

@ -725,7 +725,8 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn,
NULL); NULL);
virCommandAddArg(cmd, "-L"); virCommandAddArg(cmd, "-L");
if (vol->capacity != vol->allocation) { if (vol->capacity != vol->allocation) {
virCommandAddArgFormat(cmd, "%lluK", VIR_DIV_UP(vol->allocation, 1024)); virCommandAddArgFormat(cmd, "%lluK",
VIR_DIV_UP(vol->allocation ? vol->allocation : 1, 1024));
virCommandAddArg(cmd, "--virtualsize"); virCommandAddArg(cmd, "--virtualsize");
} }
virCommandAddArgFormat(cmd, "%lluK", VIR_DIV_UP(vol->capacity, 1024)); virCommandAddArgFormat(cmd, "%lluK", VIR_DIV_UP(vol->capacity, 1024));