From 29aa9b02aa586491d9c7225fbc2957139c0a26fb Mon Sep 17 00:00:00 2001 From: Jiri Denemark Date: Tue, 8 Oct 2024 12:26:44 +0200 Subject: [PATCH] qemu: Replace big condition in virQEMUCapsCPUFilterFeatures with array MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 1d7ac9803d..f930ad2acf 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3531,22 +3531,26 @@ virQEMUCapsProbeQMPSGXCapabilities(virQEMUCaps *qemuCaps, * QEMU never supported them or they were dropped as they never did anything * useful. */ +const char *ignoredFeatures[] = { + "cmt", "mbm_total", "mbm_local", /* never supported by QEMU */ + "osxsave", "ospke", /* dropped from QEMU */ +}; + bool virQEMUCapsCPUFilterFeatures(const char *name, virCPUFeaturePolicy policy G_GNUC_UNUSED, void *opaque) { virArch *arch = opaque; + size_t i; if (!ARCH_IS_X86(*arch)) return true; - if (STREQ(name, "cmt") || - STREQ(name, "mbm_total") || - STREQ(name, "mbm_local") || - STREQ(name, "osxsave") || - STREQ(name, "ospke")) - return false; + for (i = 0; i < G_N_ELEMENTS(ignoredFeatures); i++) { + if (STREQ(name, ignoredFeatures[i])) + return false; + } return true; }