External/libvirt
1
0
Fork 0
Code

remote_daemon_dispatch: Don't leak @ret on failure

Browse Source 
If there's a problem in encoding @ret (for instance
virTypedParamsSerialize() fails) then @ret is leaked.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Michal Privoznik 2019-08-27 11:47:52 +02:00
parent 86720ef139
commit 29db40040c
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/remote/remote_daemon_dispatch.c
View File

@ -7025,8 +7025,11 @@ remoteDispatchConnectGetAllDomainStats(virNetServerPtr server ATTRIBUTE_UNUSED,
rv = 0; rv = 0;
cleanup: cleanup:
if (rv < 0) if (rv < 0) {
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
xdr_free((xdrproc_t)xdr_remote_connect_get_all_domain_stats_ret,
(char *) ret);
}
virDomainStatsRecordListFree(retStats); virDomainStatsRecordListFree(retStats);
virObjectListFree(doms); virObjectListFree(doms);