diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index 7a81c10fd1..35f8128e70 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -516,62 +516,50 @@ virDomainCapsFeatureGICFormat(virBufferPtr buf, } -static int -virDomainCapsFormatInternal(virBufferPtr buf, - virDomainCapsPtr const caps) -{ - const char *virttype_str = virDomainVirtTypeToString(caps->virttype); - const char *arch_str = virArchToString(caps->arch); - - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); - - virBufferEscapeString(buf, "%s\n", caps->path); - virBufferAsprintf(buf, "%s\n", virttype_str); - if (caps->machine) - virBufferAsprintf(buf, "%s\n", caps->machine); - virBufferAsprintf(buf, "%s\n", arch_str); - - if (caps->maxvcpus) - virBufferAsprintf(buf, "\n", caps->maxvcpus); - - virDomainCapsOSFormat(buf, &caps->os); - virDomainCapsCPUFormat(buf, &caps->cpu); - - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); - - virDomainCapsDeviceDiskFormat(buf, &caps->disk); - virDomainCapsDeviceGraphicsFormat(buf, &caps->graphics); - virDomainCapsDeviceVideoFormat(buf, &caps->video); - virDomainCapsDeviceHostdevFormat(buf, &caps->hostdev); - - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); - - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); - - virDomainCapsFeatureGICFormat(buf, &caps->gic); - - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); - - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); - return 0; -} - - char * virDomainCapsFormat(virDomainCapsPtr const caps) { virBuffer buf = VIR_BUFFER_INITIALIZER; + const char *virttype_str = virDomainVirtTypeToString(caps->virttype); + const char *arch_str = virArchToString(caps->arch); - if (virDomainCapsFormatInternal(&buf, caps) < 0) { - virBufferFreeAndReset(&buf); - return NULL; - } + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); + virBufferEscapeString(&buf, "%s\n", caps->path); + virBufferAsprintf(&buf, "%s\n", virttype_str); + if (caps->machine) + virBufferAsprintf(&buf, "%s\n", caps->machine); + virBufferAsprintf(&buf, "%s\n", arch_str); + + if (caps->maxvcpus) + virBufferAsprintf(&buf, "\n", caps->maxvcpus); + + virDomainCapsOSFormat(&buf, &caps->os); + virDomainCapsCPUFormat(&buf, &caps->cpu); + + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); + + virDomainCapsDeviceDiskFormat(&buf, &caps->disk); + virDomainCapsDeviceGraphicsFormat(&buf, &caps->graphics); + virDomainCapsDeviceVideoFormat(&buf, &caps->video); + virDomainCapsDeviceHostdevFormat(&buf, &caps->hostdev); + + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); + + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); + + virDomainCapsFeatureGICFormat(&buf, &caps->gic); + + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); + + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); + + virBufferCheckError(&buf); return virBufferContentAndReset(&buf); }