External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-20 21:19:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virNetDevBandwidthParseRate: Reject negative values

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=1022292

The following XML really does not make any sense:

<inbound average="-1" burst="-2" peak="-3" floor="-4"/>

There can't be a negative packet rate. Well, so far we haven't
assigned any meaning to it. So reject it unless users harm themselves,
because otherwise we turn the negative numbers into really big values.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2015-08-07 17:03:12 +02:00
parent 17cba9fb51
commit 2a5d3f227d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/conf/netdev_bandwidth_conf.c
View File

@ -50,7 +50,7 @@ virNetDevBandwidthParseRate(xmlNodePtr node, virNetDevBandwidthRatePtr rate)
floor = virXMLPropString(node, "floor"); floor = virXMLPropString(node, "floor");
if (average) { if (average) {
if (virStrToLong_ull(average, NULL, 10, &rate->average) < 0) { if (virStrToLong_ullp(average, NULL, 10, &rate->average) < 0) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("could not convert bandwidth average value '%s'"), _("could not convert bandwidth average value '%s'"),
average); average);
@ -68,21 +68,21 @@ virNetDevBandwidthParseRate(xmlNodePtr node, virNetDevBandwidthRatePtr rate)
goto cleanup; goto cleanup;
} }
if (peak && virStrToLong_ull(peak, NULL, 10, &rate->peak) < 0) { if (peak && virStrToLong_ullp(peak, NULL, 10, &rate->peak) < 0) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("could not convert bandwidth peak value '%s'"), _("could not convert bandwidth peak value '%s'"),
peak); peak);
goto cleanup; goto cleanup;
} }
if (burst && virStrToLong_ull(burst, NULL, 10, &rate->burst) < 0) { if (burst && virStrToLong_ullp(burst, NULL, 10, &rate->burst) < 0) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("could not convert bandwidth burst value '%s'"), _("could not convert bandwidth burst value '%s'"),
burst); burst);
goto cleanup; goto cleanup;
} }
if (floor && virStrToLong_ull(floor, NULL, 10, &rate->floor) < 0) { if (floor && virStrToLong_ullp(floor, NULL, 10, &rate->floor) < 0) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("could not convert bandwidth floor value '%s'"), _("could not convert bandwidth floor value '%s'"),
floor); floor);