External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

virfirewall: virFirewallAddRuleFullV: Remove OOM check from VIR_APPEND_ELEMENT

Browse Source 
VIR_APPEND_ELEMENT_COPY will abort the program on OOM so there's no need
to check.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-23 17:38:18 +01:00
parent 1a1a926804
commit 2a620b1200
1 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/util/virfirewall.c
View File

@ -315,24 +315,17 @@ virFirewallAddRuleFullV(virFirewallPtr firewall,
ADD_ARG(rule, str);
if (group->addingRollback) {
if (VIR_APPEND_ELEMENT_COPY(group->rollback,
group->nrollback,
rule) < 0)
goto no_memory;
ignore_value(VIR_APPEND_ELEMENT_COPY(group->rollback,
group->nrollback,
rule));
} else {
if (VIR_APPEND_ELEMENT_COPY(group->action,
group->naction,
rule) < 0)
goto no_memory;
ignore_value(VIR_APPEND_ELEMENT_COPY(group->action,
group->naction,
rule));
}
return rule;
no_memory:
firewall->err = ENOMEM;
virFirewallRuleFree(rule);
return NULL;
}