From 2d0fc93fdd6de6d1bc2d3b1b2af69bdd51205f79 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 28 Nov 2011 17:43:51 +0100 Subject: [PATCH] virsh: Don't traverse childless nodes in vshNodeIsSuperset If both nodes do not have any children, we pass zero to virBitmapAlloc which returns NULL. In turn we report OOM error and return false (meaning nodes are different). This is not true. --- tools/virsh.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index 16d815c9ad..6ed249ba45 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11556,6 +11556,9 @@ vshNodeIsSuperset(xmlNodePtr n1, xmlNodePtr n2) if (n1_child_size < n2_child_size) return false; + if (n1_child_size == 0 && n2_child_size == 0) + return true; + if (!(bitmap = virBitmapAlloc(n1_child_size))) { virReportOOMError(); return false;