External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

storage: Resolve storage driver crash

Browse Source 
Resolve a storage driver crash as a result of a long running
storageVolCreateXML when the virStorageVolPoolRefreshThread is
run as a result of when a storageVolUpload completed and ran the
virStoragePoolObjClearVols without checking if the creation
code was currently processing a buildVol after incrementing
the driver->asyncjob count.

The refreshThread will now check the pool asyncjob count before
attempting to pursue the pool refresh. Adjust the documentation
to describe the condition.

Crash from valgrind is as follows (with a bit of editing):

==21309== Invalid read of size 8
==21309==    at 0x153E47AF: storageBackendUpdateVolTargetInfo
==21309==    by 0x153E4C30: virStorageBackendUpdateVolInfo
==21309==    by 0x153E52DE: virStorageBackendVolRefreshLocal
==21309==    by 0x153DE29E: storageVolCreateXML
==21309==    by 0x562035B: virStorageVolCreateXML
==21309==    by 0x147366: remoteDispatchStorageVolCreateXML
...
==21309==  Address 0x2590a720 is 64 bytes inside a block of size 336 free'd
==21309==    at 0x4C2F2BB: free
==21309==    by 0x54CB9FA: virFree
==21309==    by 0x55BC800: virStorageVolDefFree
==21309==    by 0x55BF1D8: virStoragePoolObjClearVols
==21309==    by 0x153D967E: virStorageVolPoolRefreshThread
...
==21309==  Block was alloc'd at
==21309==    at 0x4C300A5: calloc
==21309==    by 0x54CB483: virAlloc
==21309==    by 0x55BDC1F: virStorageVolDefParseXML
==21309==    by 0x55BDC1F: virStorageVolDefParseNode
==21309==    by 0x55BE5A4: virStorageVolDefParse
==21309==    by 0x153DDFF1: storageVolCreateXML
==21309==    by 0x562035B: virStorageVolCreateXML
==21309==    by 0x147366: remoteDispatchStorageVolCreateXML
...
This commit is contained in:
John Ferlan 2017-11-06 15:22:07 -05:00
parent b98add7571
commit 2dd70901db
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/libvirt-storage.c
View File

@ -1632,7 +1632,8 @@ virStorageVolDownload(virStorageVolPtr vol,
* another active stream is writing to the storage volume. * another active stream is writing to the storage volume.
* *
* When the data stream is closed whether the upload is successful * When the data stream is closed whether the upload is successful
* or not the target storage pool will be refreshed to reflect pool * or not an attempt will be made to refresh the target storage pool
* if an asynchronous build is not running in order to reflect pool
* and volume changes as a result of the upload. Depending on * and volume changes as a result of the upload. Depending on
* the target volume storage backend and the source stream type * the target volume storage backend and the source stream type
* for a successful upload, the target volume may take on the * for a successful upload, the target volume may take on the

7
src/storage/storage_driver.c
View File

@ -2267,6 +2267,13 @@ virStorageVolPoolRefreshThread(void *opaque)
goto cleanup; goto cleanup;
def = virStoragePoolObjGetDef(obj); def = virStoragePoolObjGetDef(obj);
/* If some thread is building a new volume in the pool, then we cannot
* clear out all vols and refresh the pool. So we'll just pass. */
if (virStoragePoolObjGetAsyncjobs(obj) > 0) {
VIR_DEBUG("Asyncjob in process, cannot refresh storage pool");
goto cleanup;
}
if (!(backend = virStorageBackendForType(def->type))) if (!(backend = virStorageBackendForType(def->type)))
goto cleanup; goto cleanup;