External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-24 05:25:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Small fixes for qemu save compression.

Browse Source 
Fix up a small memory leak pointed out by DanB; I was forgetting
to release memory allocated to driver->saveImageFormat.
Also add the "save_image_format" and "security" entries to
the augeas lens.

Signed-off-by: Chris Lalancette <clalance@redhat.com>
This commit is contained in:
Chris Lalancette 2009-08-17 12:34:53 +02:00
parent da8b7c9f89
commit 2e7c8b0b6f
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qemud/libvirtd_qemu.aug
View File

@ -29,10 +29,12 @@ module Libvirtd_qemu =
| str_entry "vnc_password" | str_entry "vnc_password"
| bool_entry "vnc_sasl" | bool_entry "vnc_sasl"
| str_entry "vnc_sasl_dir" | str_entry "vnc_sasl_dir"
| str_entry "security_driver"
| str_entry "user" | str_entry "user"
| str_entry "group" | str_entry "group"
| str_array_entry "cgroup_controllers" | str_array_entry "cgroup_controllers"
| str_array_entry "cgroup_device_acl" | str_array_entry "cgroup_device_acl"
| str_entry "save_image_format"
(* Each enty in the config is one of the following three ... *) (* Each enty in the config is one of the following three ... *)
let entry = vnc_entry let entry = vnc_entry

10
qemud/test_libvirtd_qemu.aug
View File

@ -80,6 +80,8 @@ vnc_sasl = 1
# #
vnc_sasl_dir = \"/some/directory/sasl2\" vnc_sasl_dir = \"/some/directory/sasl2\"
security_driver = \"selinux\"
user = \"root\" user = \"root\"
group = \"root\" group = \"root\"
@ -87,6 +89,8 @@ group = \"root\"
cgroup_controllers = [ \"cpu\", \"devices\" ] cgroup_controllers = [ \"cpu\", \"devices\" ]
cgroup_device_acl = [ \"/dev/null\", \"/dev/full\", \"/dev/zero\" ] cgroup_device_acl = [ \"/dev/null\", \"/dev/full\", \"/dev/zero\" ]
save_image_format = \"gzip\"
" "
test Libvirtd_qemu.lns get conf = test Libvirtd_qemu.lns get conf =
@ -170,7 +174,9 @@ cgroup_device_acl = [ \"/dev/null\", \"/dev/full\", \"/dev/zero\" ]
{ "#comment" = "" } { "#comment" = "" }
{ "vnc_sasl_dir" = "/some/directory/sasl2" } { "vnc_sasl_dir" = "/some/directory/sasl2" }
{ "#empty" } { "#empty" }
{ "user"= "root" } { "security_driver" = "selinux" }
{ "#empty" }
{ "user" = "root" }
{ "#empty" } { "#empty" }
{ "group" = "root" } { "group" = "root" }
{ "#empty" } { "#empty" }
@ -184,3 +190,5 @@ cgroup_device_acl = [ \"/dev/null\", \"/dev/full\", \"/dev/zero\" ]
{ "2" = "/dev/full" } { "2" = "/dev/full" }
{ "3" = "/dev/zero" } { "3" = "/dev/zero" }
} }
{ "#empty" }
{ "save_image_format" = "gzip" }

1
src/qemu_driver.c
View File

@ -672,6 +672,7 @@ qemudShutdown(void) {
VIR_FREE(qemu_driver->vncListen); VIR_FREE(qemu_driver->vncListen);
VIR_FREE(qemu_driver->vncPassword); VIR_FREE(qemu_driver->vncPassword);
VIR_FREE(qemu_driver->vncSASLdir); VIR_FREE(qemu_driver->vncSASLdir);
VIR_FREE(qemu_driver->saveImageFormat);
/* Free domain callback list */ /* Free domain callback list */
virDomainEventCallbackListFree(qemu_driver->domainEventCallbacks); virDomainEventCallbackListFree(qemu_driver->domainEventCallbacks);