External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: virschema: Propagate errors from directory traversal in testSchemaDir

Browse Source 
testSchemaDir is a helper which invokes the schema test using virTestRun
on all schema files. Since the function itself is not called inside
virTestRun any helper function call is not dispatched to the user and
thus it's hard to debug the test. Propagate errors from the directory
traversal.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2019-11-19 11:55:05 +01:00
parent d154807d5b
commit 2eb7c68332
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/virschematest.c
View File

@ -76,8 +76,10 @@ testSchemaDir(const char *schema,
.validator = validator,
};
if (virDirOpen(&dir, dir_path) < 0)
if (virDirOpen(&dir, dir_path) < 0) {
virTestPropagateLibvirtError();
return -1;
}
while ((rc = virDirRead(dir, &ent, dir_path)) > 0) {
g_autofree char *test_name = NULL;
@ -97,8 +99,10 @@ testSchemaDir(const char *schema,
ret = -1;
}
if (rc < 0)
if (rc < 0) {
virTestPropagateLibvirtError();
ret = -1;
}
VIR_DIR_CLOSE(dir);
return ret;