External/libvirt
1
0
Fork 0
Code

xenapi: Resolve Coverity NO_EFFECT

Browse Source 
Coverity points out that check (def->uuid) has no effect since it's not
a pointer, rather an array of characters.   Just remove the extranous check.

(cherry picked from commit 467c90590924069d64a4cd884abef17c7c2c0f24)
This commit is contained in:
John Ferlan 2015-03-10 18:41:18 -04:00 committed by Cole Robinson
parent 2213707b6b
commit 2f26dccb65
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/xenapi/xenapi_utils.c
View File

@ -455,11 +455,9 @@ createVMRecordFromXml(virConnectPtr conn, virDomainDefPtr def,
*record = xen_vm_record_alloc(); *record = xen_vm_record_alloc();
if (VIR_STRDUP((*record)->name_label, def->name) < 0) if (VIR_STRDUP((*record)->name_label, def->name) < 0)
goto error; goto error;
if (def->uuid) { virUUIDFormat(def->uuid, uuidStr);
virUUIDFormat(def->uuid, uuidStr); if (VIR_STRDUP((*record)->uuid, uuidStr) < 0)
if (VIR_STRDUP((*record)->uuid, uuidStr) < 0) goto error;
goto error;
}
if (STREQ(def->os.type, "hvm")) { if (STREQ(def->os.type, "hvm")) {
char *boot_order = NULL; char *boot_order = NULL;
if (VIR_STRDUP((*record)->hvm_boot_policy, "BIOS order") < 0) if (VIR_STRDUP((*record)->hvm_boot_policy, "BIOS order") < 0)