External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-23 13:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

storage: mpath: Don't error on target_type=NULL

Browse Source 
We use device-mapper to enumerate all dm devices, and filter out
the list of multipath devices by checking the target_type string
name. The code however cancels all scanning if we encounter
target_type=NULL

I don't know how to reproduce that situation, but a user was hitting
it in their setup, and inspecting the lvm2/device-mapper code shows
many places where !target_type is explicitly ignored and processing
continues on to the next device. So I think we should do the same

https://bugzilla.redhat.com/show_bug.cgi?id=1069317
(cherry picked from commit 8f8c0feb113420625f15b7f1e17bfd719c977eeb)
This commit is contained in:
Cole Robinson 2016-04-13 17:29:59 -04:00
parent 886cfe71ae
commit 2f80aed70e
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/storage/storage_backend_mpath.c
View File

@ -114,12 +114,7 @@ virStorageBackendIsMultipath(const char *dev_name)
dm_get_next_target(dmt, next, &start, &length, &target_type, &params); dm_get_next_target(dmt, next, &start, &length, &target_type, &params);
if (target_type == NULL) { if (STREQ_NULLABLE(target_type, "multipath"))
ret = -1;
goto out;
}
if (STREQ(target_type, "multipath"))
ret = 1; ret = 1;
out: out: