External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

logging.c: Properly indent and ignore one syntax-check rule

Browse Source 
With our fix of mkostemp (pushed as 2b435c15) we define a macro
to compile with uclibc. However, this definition is conditional
and thus needs to be properly indented. Moreover, with this definition
sc_prohibit_mkstemp syntax-check rule keeps yelling:

  src/util/logging.c:63:# define mkostemp(x,y) mkstemp(x)
  maint.mk: use mkostemp with O_CLOEXEC instead of mkstemp

Therefore we should ignore this file for this rule.
This commit is contained in:
Michal Privoznik 2012-11-02 11:07:54 +01:00
parent 1851a0c864
commit 30b398d5ef
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cfg.mk
View File

@ -817,3 +817,5 @@ exclude_file_name_regexp--sc_unmarked_diagnostics = \
^(docs/apibuild.py|tests/virt-aa-helper-test)$$
exclude_file_name_regexp--sc_size_of_brackets = cfg.mk
exclude_file_name_regexp--sc_prohibit_mkstemp = ^src/util/logging\.c$$

2
src/util/logging.c
View File

@ -60,7 +60,7 @@
#ifdef __UCLIBC__
/* uclibc does not implement mkostemp GNU extention */
#define mkostemp(x,y) mkstemp(x)
# define mkostemp(x,y) mkstemp(x)
#endif
VIR_ENUM_DECL(virLogSource)