External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-13 00:01:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: dump: Report better error when dumping VM with passthrough devices

Browse Source 
For the regular dump operation we migrate the VM to a file. This won't
work when the VM has passthrough devices assigned. Rather than reporting
a cryptic error from qemu run our check whether it can be migrated.

This does not influence the memory-only dump that is allowed with
passthrough devices.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=874418
This commit is contained in:
Peter Krempa 2014-07-07 10:00:46 +02:00
parent 3d41eb310e
commit 315fba9c60
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_driver.c
View File

@ -3481,6 +3481,10 @@ doCoreDump(virQEMUDriverPtr driver,
"memory-only dump")); "memory-only dump"));
goto cleanup; goto cleanup;
} }
if (!qemuMigrationIsAllowed(driver, vm, vm->def, false, false))
goto cleanup;
ret = qemuMigrationToFile(driver, vm, fd, 0, path, ret = qemuMigrationToFile(driver, vm, fd, 0, path,
qemuCompressProgramName(compress), false, qemuCompressProgramName(compress), false,
QEMU_ASYNC_JOB_DUMP); QEMU_ASYNC_JOB_DUMP);