External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-30 09:53:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

nodeinfo: Add coverity[dead_error_begin] and [returned_null] tags

Browse Source 
The use of switch statements inside a bounded for loop resulted in some
false positives regarding the "default:" label which cannot be reached
since each of the other case statements use the possible for loop values.
A [dead_error_begin] was added before the default label.

Commit id ebdbe25a adjusted the algorithm and the caller guarantees that
the 'params' will have a '_' in the name being searched. Add the [returned_null]
tag to the two instances.
This commit is contained in:
John Ferlan 2013-01-22 09:40:58 -05:00 committed by Michal Privoznik
parent 15666e026f
commit 316ed4128b
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/nodeinfo.c
View File

@ -1124,6 +1124,7 @@ nodeSetMemoryParameterValue(virTypedParameterPtr param)
int ret = -1;
int rc = -1;
/* coverity[returned_null] */
char *field = strchr(param->field, '_');
field++;
if (virAsprintf(&path, "%s/%s",
@ -1161,6 +1162,7 @@ nodeMemoryParametersIsAllSupported(virTypedParameterPtr params,
for (i = 0; i < nparams; i++) {
virTypedParameterPtr param = &params[i];
/* coverity[returned_null] */
char *field = strchr(param->field, '_');
field++;
if (virAsprintf(&path, "%s/%s",
@ -1413,6 +1415,7 @@ nodeGetMemoryParameters(virConnectPtr conn ATTRIBUTE_UNUSED,
break;
/* coverity[dead_error_begin] */
default:
break;
}