External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: remove outdated suggestion to make patches with "diff -urp"/"git diff"

Browse Source 
I can't think of any good reason to do either of those, and having the
examples there will just lead to unusable patch emails from people who
can't be bothered to read the entire page.
This commit is contained in:
Laine Stump 2016-06-29 15:36:31 -04:00
parent 9c992f437c
commit 328fccf135
2 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
HACKING
View File

@ -23,19 +23,11 @@ libvirt-python) online <http://libvirt.org/git/>.
join the appropriate language team. The libvirt release process automatically join the appropriate language team. The libvirt release process automatically
pulls the latest version of each translation file from zanata. pulls the latest version of each translation file from zanata.
(4) Post patches in unified diff format, with git rename detection enabled. You (4) Post patches using "git send-email", with git rename detection enabled. You
need a one-time setup of: need a one-time setup of:
git config diff.renames true git config diff.renames true
After that, a command similar to this should work:
diff -urp libvirt.orig/ libvirt.modified/ > libvirt-myfeature.patch
or:
git diff > libvirt-myfeature.patch
Also, for code motion patches, you may find that "git diff --patience" Also, for code motion patches, you may find that "git diff --patience"
provides an easier-to-read patch. However, the usual workflow of libvirt provides an easier-to-read patch. However, the usual workflow of libvirt
developer is: developer is:

12
docs/hacking.html.in
View File

@ -23,20 +23,10 @@
automatically pulls the latest version of each translation automatically pulls the latest version of each translation
file from zanata.</li> file from zanata.</li>
<li><p>Post patches in unified diff format, with git rename <li><p>Post patches using "git send-email", with git rename
detection enabled. You need a one-time setup of:</p> detection enabled. You need a one-time setup of:</p>
<pre> <pre>
git config diff.renames true git config diff.renames true
</pre>
<p>After that, a command similar to this should work:</p>
<pre>
diff -urp libvirt.orig/ libvirt.modified/ &gt; libvirt-myfeature.patch
</pre>
<p>
or:
</p>
<pre>
git diff &gt; libvirt-myfeature.patch
</pre> </pre>
<p>Also, for code motion patches, you may find that <code>git <p>Also, for code motion patches, you may find that <code>git
diff --patience</code> provides an easier-to-read patch. diff --patience</code> provides an easier-to-read patch.