External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: Annotate "unwanted_positional" arguments for 'pool-(define|create)-as' commands

Browse Source 
Annotate arguments which can be unintentionally parsed positionally.
(See previous commits for explanation.)

All of these options were added in order thus we must declare all of
them as 'unwanted_positional'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2024-03-13 22:54:05 +01:00
parent e31cd46364
commit 32a89fc670
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/virsh-pool.c
View File

@ -76,80 +76,99 @@
}, \ }, \
{.name = "source-host", \ {.name = "source-host", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.completer = virshCompleteEmpty, \ .completer = virshCompleteEmpty, \
.help = N_("source-host for underlying storage") \ .help = N_("source-host for underlying storage") \
}, \ }, \
{.name = "source-path", \ {.name = "source-path", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("source path for underlying storage") \ .help = N_("source path for underlying storage") \
}, \ }, \
{.name = "source-dev", \ {.name = "source-dev", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("source device for underlying storage") \ .help = N_("source device for underlying storage") \
}, \ }, \
{.name = "source-name", \ {.name = "source-name", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("source name for underlying storage") \ .help = N_("source name for underlying storage") \
}, \ }, \
{.name = "target", \ {.name = "target", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("target for underlying storage") \ .help = N_("target for underlying storage") \
}, \ }, \
{.name = "source-format", \ {.name = "source-format", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("format for underlying storage") \ .help = N_("format for underlying storage") \
}, \ }, \
{.name = "auth-type", \ {.name = "auth-type", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("auth type to be used for underlying storage") \ .help = N_("auth type to be used for underlying storage") \
}, \ }, \
{.name = "auth-username", \ {.name = "auth-username", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.completer = virshCompleteEmpty, \ .completer = virshCompleteEmpty, \
.help = N_("auth username to be used for underlying storage") \ .help = N_("auth username to be used for underlying storage") \
}, \ }, \
{.name = "secret-usage", \ {.name = "secret-usage", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("auth secret usage to be used for underlying storage") \ .help = N_("auth secret usage to be used for underlying storage") \
}, \ }, \
{.name = "secret-uuid", \ {.name = "secret-uuid", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("auth secret UUID to be used for underlying storage") \ .help = N_("auth secret UUID to be used for underlying storage") \
}, \ }, \
{.name = "adapter-name", \ {.name = "adapter-name", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter name to be used for underlying storage") \ .help = N_("adapter name to be used for underlying storage") \
}, \ }, \
{.name = "adapter-wwnn", \ {.name = "adapter-wwnn", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter wwnn to be used for underlying storage") \ .help = N_("adapter wwnn to be used for underlying storage") \
}, \ }, \
{.name = "adapter-wwpn", \ {.name = "adapter-wwpn", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter wwpn to be used for underlying storage") \ .help = N_("adapter wwpn to be used for underlying storage") \
}, \ }, \
{.name = "adapter-parent", \ {.name = "adapter-parent", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter parent scsi_hostN to be used for underlying vHBA storage") \ .help = N_("adapter parent scsi_hostN to be used for underlying vHBA storage") \
}, \ }, \
{.name = "adapter-parent-wwnn", \ {.name = "adapter-parent-wwnn", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter parent scsi_hostN wwnn to be used for underlying vHBA storage") \ .help = N_("adapter parent scsi_hostN wwnn to be used for underlying vHBA storage") \
}, \ }, \
{.name = "adapter-parent-wwpn", \ {.name = "adapter-parent-wwpn", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter parent scsi_hostN wwpn to be used for underlying vHBA storage") \ .help = N_("adapter parent scsi_hostN wwpn to be used for underlying vHBA storage") \
}, \ }, \
{.name = "adapter-parent-fabric-wwn", \ {.name = "adapter-parent-fabric-wwn", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("adapter parent scsi_hostN fabric_wwn to be used for underlying vHBA storage") \ .help = N_("adapter parent scsi_hostN fabric_wwn to be used for underlying vHBA storage") \
}, \ }, \
{.name = "source-protocol-ver", \ {.name = "source-protocol-ver", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.help = N_("nfsvers value for NFS pool mount option") \ .help = N_("nfsvers value for NFS pool mount option") \
}, \ }, \
{.name = "source-initiator", \ {.name = "source-initiator", \
.type = VSH_OT_STRING, \ .type = VSH_OT_STRING, \
.unwanted_positional = true, \
.completer = virshCompleteEmpty, \ .completer = virshCompleteEmpty, \
.help = N_("initiator iqn for underlying storage") \ .help = N_("initiator iqn for underlying storage") \
} }