External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: Report errors in all code paths in virPolkitAgentCreate

Browse Source 
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Martin Kletzander 2021-11-19 16:20:25 +01:00
parent 0ac13b189f
commit 32eae6fd31
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/util/virpolkit.c
View File

@ -180,8 +180,11 @@ virPolkitAgentCreate(void)
int outfd = STDOUT_FILENO;
int errfd = STDERR_FILENO;
if (!isatty(STDIN_FILENO))
if (!isatty(STDIN_FILENO)) {
virReportError(VIR_ERR_SYSTEM_ERROR, "%s",
_("Cannot start polkit text agent without a tty"));
goto error;
}
if (virPipe(pipe_fd) < 0)
goto error;
@ -205,8 +208,11 @@ virPolkitAgentCreate(void)
pollfd.fd = pipe_fd[0];
pollfd.events = POLLHUP;
if (poll(&pollfd, 1, -1) < 0)
if (poll(&pollfd, 1, -1) < 0) {
virReportSystemError(errno, "%s",
_("error in poll call"));
goto error;
}
return agent;