From 3353c7c40ad1c586904e33eee57bba4da1706e5e Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Tue, 17 Mar 2015 17:44:50 +0100 Subject: [PATCH] qemuGetDHCPInterfaces: Don't leak @network The function needs a pointer to the network to get list of DHCP leases. The pointer is obtained via virNetworkLookupByName() which requires callers to free the returned network once no longer needed. Otherwise it's leaked. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e0b672357f..ed6764d548 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19652,7 +19652,7 @@ qemuGetDHCPInterfaces(virDomainPtr dom, int n_leases = 0; size_t i, j; size_t ifaces_count = 0; - virNetworkPtr network; + virNetworkPtr network = NULL; char macaddr[VIR_MAC_STRING_BUFLEN]; virDomainInterfacePtr iface = NULL; virNetworkDHCPLeasePtr *leases = NULL; @@ -19670,6 +19670,7 @@ qemuGetDHCPInterfaces(virDomainPtr dom, continue; virMacAddrFormat(&(vm->def->nets[i]->mac), macaddr); + virObjectUnref(network); network = virNetworkLookupByName(dom->conn, vm->def->nets[i]->data.network.name); @@ -19720,6 +19721,7 @@ qemuGetDHCPInterfaces(virDomainPtr dom, rv = ifaces_count; cleanup: + virObjectUnref(network); if (leases) { for (i = 0; i < n_leases; i++) virNetworkDHCPLeaseFree(leases[i]);