External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 06:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuProcessReconnectHelper: Don't create joinable thread

Browse Source 
In the qemuProcessReconnectHelper() a new thread that does all the
interesting work is spawned. The rationale is to not block the daemon
startup process in case of unresponsive qemu. However, the thread
handler is a local variable which gets lost once the control goes out of
scope. Hence the thread gets leaked. We can avoid this if the thread
isn't made joinable.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2013-11-14 10:42:52 +01:00
parent ea13a759f5
commit 3367c21dad
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_process.c
View File

@ -3281,7 +3281,7 @@ qemuProcessReconnectHelper(virDomainObjPtr obj,
*/ */
virConnectRef(data->conn); virConnectRef(data->conn);
if (virThreadCreate(&thread, true, qemuProcessReconnect, data) < 0) { if (virThreadCreate(&thread, false, qemuProcessReconnect, data) < 0) {
virConnectClose(data->conn); virConnectClose(data->conn);