mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-30 21:47:18 +00:00
node_device: Check return value for udev_new()
The comment was actually wrong as https://www.freedesktop.org/software/systemd/man/udev_new.html# mentions that on failure NULL is returned. Also the same return value is checked in src/interface/interface_backend_udev.c already. Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
This commit is contained in:
parent
579fc9a287
commit
3427b36cc1
@ -1563,13 +1563,12 @@ static int nodeStateInitialize(bool privileged,
|
|||||||
if (udevPCITranslateInit(privileged) < 0)
|
if (udevPCITranslateInit(privileged) < 0)
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
|
|
||||||
/*
|
|
||||||
* http://www.kernel.org/pub/linux/utils/kernel/hotplug/libudev/libudev-udev.html#udev-new
|
|
||||||
*
|
|
||||||
* indicates no return value other than success, so we don't check
|
|
||||||
* its return value.
|
|
||||||
*/
|
|
||||||
udev = udev_new();
|
udev = udev_new();
|
||||||
|
if (!udev) {
|
||||||
|
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
||||||
|
_("failed to create udev context"));
|
||||||
|
goto cleanup;
|
||||||
|
}
|
||||||
#if HAVE_UDEV_LOGGING
|
#if HAVE_UDEV_LOGGING
|
||||||
/* cast to get rid of missing-format-attribute warning */
|
/* cast to get rid of missing-format-attribute warning */
|
||||||
udev_set_log_fn(udev, (udevLogFunctionPtr) udevLogFunction);
|
udev_set_log_fn(udev, (udevLogFunctionPtr) udevLogFunction);
|
||||||
|
Loading…
Reference in New Issue
Block a user