External/libvirt
1
0
Fork 0
Code

qemu: Disable NBD TLS migration over UNIX socket

Browse Source 
Even though it is technically possible, when running the migrations QEMU's
nbd-server-start errors out with:

  "TLS is only supported with IPv4/IPv6"

We can always enable it when QEMU adds this feature, but for now it is safer to
show our error message rather than rely on QEMU to error out properly.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Martin Kletzander 2020-11-18 13:51:05 +01:00
parent d1e00f84c0
commit 3430a77182
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_migration.c
View File

@ -1100,6 +1100,12 @@ qemuMigrationSrcNBDStorageCopy(virQEMUDriverPtr driver,
if (uri->port) if (uri->port)
port = uri->port; port = uri->port;
} else if (STREQ(uri->scheme, "unix")) { } else if (STREQ(uri->scheme, "unix")) {
if (flags & VIR_MIGRATE_TLS) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("NBD migration with TLS is not supported over UNIX socket"));
return -1;
}
if (!uri->path) { if (!uri->path) {
virReportError(VIR_ERR_INVALID_ARG, "%s", virReportError(VIR_ERR_INVALID_ARG, "%s",
_("UNIX disks URI does not include path")); _("UNIX disks URI does not include path"));