External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

interface: fix udev reference leak with invalid flags

Browse Source 
The udevInterfaceGetXMLDesc method takes a reference on the udev
driver as its first action. If the virCheckFlags() condition
fails, however, this reference is never released.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2024-06-05 11:16:21 +01:00
parent 98f1cf88fa
commit 3499354e12
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/interface/interface_backend_udev.c
View File

@ -1027,12 +1027,14 @@ static char *
udevInterfaceGetXMLDesc(virInterfacePtr ifinfo, udevInterfaceGetXMLDesc(virInterfacePtr ifinfo,
unsigned int flags) unsigned int flags)
{ {
struct udev *udev = udev_ref(driver->udev); struct udev *udev = NULL;
g_autoptr(virInterfaceDef) ifacedef = NULL; g_autoptr(virInterfaceDef) ifacedef = NULL;
char *xmlstr = NULL; char *xmlstr = NULL;
virCheckFlags(VIR_INTERFACE_XML_INACTIVE, NULL); virCheckFlags(VIR_INTERFACE_XML_INACTIVE, NULL);
udev = udev_ref(driver->udev);
/* Recursively build up the interface XML based on the requested /* Recursively build up the interface XML based on the requested
* interface name * interface name
*/ */