From 34fb67efae1d0ab2bd7f6177308061c0970b8486 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Tue, 12 Dec 2017 15:00:15 +0100 Subject: [PATCH] xenMakeIPList: Don't leak @address_array ==32171== 32 bytes in 1 blocks are definitely lost in loss record 44 of 107 ==32171== at 0x4C2DEF6: calloc (vg_replace_malloc.c:711) ==32171== by 0x55744A9: virAllocN (viralloc.c:191) ==32171== by 0x12CED2: xenMakeIPList (xen_common.c:1186) ==32171== by 0x12D0BE: xenFormatNet (xen_common.c:1221) ==32171== by 0x12F0D2: xenFormatVif (xen_common.c:1889) ==32171== by 0x12F2B4: xenFormatConfigCommon (xen_common.c:1944) ==32171== by 0x13BA32: xenFormatXL (xen_xl.c:1971) ==32171== by 0x1186CA: testCompareParseXML (xlconfigtest.c:105) ==32171== by 0x118A64: testCompareHelper (xlconfigtest.c:205) ==32171== by 0x119E36: virTestRun (testutils.c:180) ==32171== by 0x11970E: mymain (xlconfigtest.c:301) ==32171== by 0x11BEE3: virTestMain (testutils.c:1119) Signed-off-by: Michal Privoznik Reviewed-by: John Ferlan --- src/xenconfig/xen_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/xenconfig/xen_common.c b/src/xenconfig/xen_common.c index 40b1483215..ff0df5fb7f 100644 --- a/src/xenconfig/xen_common.c +++ b/src/xenconfig/xen_common.c @@ -1196,8 +1196,7 @@ xenMakeIPList(virNetDevIPInfoPtr guestIP) ret = virStringListJoin((const char**)address_array, " "); cleanup: - while (i > 0) - VIR_FREE(address_array[--i]); + virStringListFree(address_array); return ret; }