External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 05:57:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't skip zero'ing end of volume file when inputvol is shorter than newvol

Browse Source 
A missing set of braces around an error condition caused us to skip
zero'ing out the remainder of a new volume file if the new volume was
longer than the original (the goto was supposed to be taken only in
the case of error, but was always being taken).
This commit is contained in:
Laine Stump 2010-07-19 18:53:38 -04:00
parent 4487d33f67
commit 35bebb5782
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/storage/storage_backend.c
View File

@ -288,9 +288,10 @@ static int createRawFileOpHook(int fd, void *data) {
if (hdata->inputvol) {
int res = virStorageBackendCopyToFD(hdata->vol, hdata->inputvol,
fd, &remain, 1);
if (res < 0)
if (res < 0) {
ret = -res;
goto cleanup;
}
}
if (remain) {