External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuMonitorOpen: Rework domain object refcounting

Browse Source 
Similarly to one of previous commits, there's no need to
increment domain object refcounter before unlocking it. Any
number of lock and unlock calls over domain object has no effect
on the refcounter.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2021-10-27 14:41:58 +02:00
parent e812213bc1
commit 3640731ed5
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/qemu/qemu_monitor.c
View File

@ -769,10 +769,6 @@ qemuMonitorOpen(virDomainObj *vm,
timeout += QEMU_DEFAULT_MONITOR_WAIT;
/* Hold an extra reference because we can't allow 'vm' to be
* deleted until the monitor gets its own reference. */
virObjectRef(vm);
if (config->type != VIR_DOMAIN_CHR_TYPE_UNIX) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("unable to handle monitor type: %s"),
@ -798,7 +794,6 @@ qemuMonitorOpen(virDomainObj *vm,
cleanup:
if (!ret)
VIR_FORCE_CLOSE(fd);
virObjectUnref(vm);
return ret;
}