External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

domain: conf: Better errors on bad os <type> values

Browse Source 
If no <os><type> was specified:
  before: unknown OS type no OS type
  after : xml error: an os <type> must be specified

If an <os><type> is specified that's not in our capabiliities data:
  before: unknown OS type: $type
  after : unsupported configuration: no support found for os <type> '$type'

VIR_ERR_OS_TYPE is now unused (as it should be frankly) so drop its strings
as well to save our translators some effort.
This commit is contained in:
Cole Robinson 2015-04-16 18:08:17 -04:00
parent 6b7b677a0e
commit 3700c065cd
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/conf/domain_conf.c
View File

@ -14638,8 +14638,8 @@ virDomainDefParseXML(xmlDocPtr xml,
if (VIR_STRDUP(def->os.type, "xen") < 0) if (VIR_STRDUP(def->os.type, "xen") < 0)
goto error; goto error;
} else { } else {
virReportError(VIR_ERR_OS_TYPE, virReportError(VIR_ERR_XML_ERROR, "%s",
"%s", _("no OS type")); _("an os <type> must be specified"));
goto error; goto error;
} }
} }
@ -14656,8 +14656,9 @@ virDomainDefParseXML(xmlDocPtr xml,
} }
if (!virCapabilitiesSupportsGuestOSType(caps, def->os.type)) { if (!virCapabilitiesSupportsGuestOSType(caps, def->os.type)) {
virReportError(VIR_ERR_OS_TYPE, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
"%s", def->os.type); _("no support found for os <type> '%s'"),
def->os.type);
goto error; goto error;
} }