External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-11 12:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Use libvirt properly with initialization and error dispatching

Browse Source 
We were using "complicated" error printing in virnetservertest even
though we could've just dispatched the error.  Also add some good
practices that might come in handy (the code may fail without proper
initialization and event loop).

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Martin Kletzander 2015-06-15 10:41:17 +02:00
parent 73ad20e936
commit 38788a3209
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/virnetservertest.c
View File

@ -119,6 +119,8 @@ testCreateServer(const char *host, int family)
goto error;
cleanup:
if (!srv)
virDispatchError(NULL);
virObjectUnref(cln1);
virObjectUnref(cln2);
virObjectUnref(svc1);
@ -235,14 +237,8 @@ static int testExecRestart(const void *opaque)
ret = 0;
cleanup:
if (ret < 0) {
virErrorPtr err = virGetLastError();
/* Rather be safe, we have lot of missing errors */
if (err)
fprintf(stderr, "%s\n", err->message);
else
fprintf(stderr, "%s\n", "Unknown error");
}
if (ret < 0)
virDispatchError(NULL);
fail:
VIR_FREE(infile);
VIR_FREE(outfile);
@ -264,6 +260,12 @@ mymain(void)
{
int ret = 0;
if (virInitialize() < 0 ||
virEventRegisterDefaultImpl() < 0) {
virDispatchError(NULL);
return EXIT_FAILURE;
}
/* Hack to make it easier to generate new JSON files when
* the RPC classes change. Just set this env var, save
* the generated JSON, and replace the file descriptor