From 39bfd6c8882d431d651acc36d22cdb7a1fad3845 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 11 Jun 2024 16:39:41 +0200 Subject: [PATCH] qemu_validate: Validate support for SCSI emulation support in 'virtio-blk' devices MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The support will be dropped soon by qemu, and libvirt is not rejecting such configurations. Add validation of this explicitly requested config. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_validate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 3c04f47a12..b82d937a0d 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2912,6 +2912,11 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDomainDiskDef *disk, break; case VIR_DOMAIN_DISK_BUS_VIRTIO: + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_BLK_SCSI)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("This QEMU doesn't support SCSI emulation with 'virtio-blk' device")); + return -1; + } break; case VIR_DOMAIN_DISK_BUS_NONE: