External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

qemuCheckpointDiscardBitmaps: Refuse to delete checkpoint with NULL bitmap name

Browse Source 
When a checkpoint is redefined without providing the domain XML, we
might end up with a definition where the per-disk bitmap name is not
set. Trying to delete such checkpoint would lead to a crash.

Refuse such deletion.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1941600
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2021-03-22 14:43:17 +01:00
parent f763b6e439
commit 3a340872f8
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/qemu/qemu_checkpoint.c
View File

@ -206,6 +206,13 @@ qemuCheckpointDiscardBitmaps(virDomainObjPtr vm,
if (chkdisk->type != VIR_DOMAIN_CHECKPOINT_TYPE_BITMAP) if (chkdisk->type != VIR_DOMAIN_CHECKPOINT_TYPE_BITMAP)
continue; continue;
if (!chkdisk->bitmap) {
virReportError(VIR_ERR_INVALID_ARG,
_("missing bitmap name for disk '%s' of checkpoint '%s'"),
chkdisk->name, chkdef->parent.name);
return -1;
}
if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, blockNamedNodeData, if (qemuCheckpointDiscardDiskBitmaps(domdisk->src, blockNamedNodeData,
chkdisk->bitmap, chkdisk->bitmap,
actions, domdisk->dst, actions, domdisk->dst,